-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port to electron + add new features #68
Conversation
- Helper menu to make it easier to create node links - Run menu to test dialogue (via bondage.js and bbcode)
add fancy b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@charblar hi thank you for looking into this. Sorry I forgot to mention that bondage.js doesnt support running the syntax The author of bondage.js @jhayley will review it when she has time, but basically adds the feature. I am going to work on this a bit more this week hopefully to clear up some corner cases where it spills an error upon completion and center the text window. The code can do with some cleaning up too :) |
@blurymind hey, no problem! I assumed that was the case. I personally know Hayley and will work with her in the coming days to resolve that. Thank you for the clarification, looking forward to your additional commits! Edit: Oops hit comment and close, damn you GitHub and your lack of confirmation messages. |
This fixes the styling problems, also cleans up some of the code on the renderer.js front
@charblar thank you for looking into that. It wasn't really intended to be a part of this pull request - and still isnt. I needed the javascript parsing capability for my personal project. So in my pull request here that is not supported, it's more of a feature for bondage.js and not yarn. On the front of this one - I fixed the previous styling problems and console errors, while also cleaning up the code.Now it should work much better :) I am now shifting my focus on this pull and will go back to bondage.js a bit later. @jhayley doesnt like the syntax |
Ok going back to bondage.js, my approach was not right, so I will create another pull request - possibly later in the week for adding support to do <<command(parameters)>> in bondage.js. For the commands - maybe later on I can add to the story tester the ability to show commands that were passed to it as well. I have noticed that it was kind of requested before |
Also the tester window now auto-closes when finished testing
Awesome, thanks for keeping us updated. Looking forward to it. |
re-enable previously stubbed file commands. Yarn-electron can now successfully do the rest of the open/save operations
Another update on this- I re-enabled all the file commands now- so the electron version is on-par with the main one. I also made some changes to my vscode start script to get it to run it from a portable flash thumb- if you are trying it- you might have to revert the changes in .vscode/tasks.json for now :) Anyways, I hope to have an electron build ready for testing soon-ish |
As a note, the changes being made to bondage.js are largely unrelated to the electron change and i recommend separating these concerns. Those feature requests aren't needed to port yarn to electron |
@jhayley yes of course. I have been using the electron port for testing the pull I am doing to bondage.js Just wanted to note that the electron port at the moment will have this feature broken for most Edit: |
A little update on this. @charblar removing command debugging resolves the change you requested :) For next update I am going to implement mid-click panning and try to also make linux and mac builds. |
This adds: - file drag and drop (including support for dropping multiple files ) - Support for deleting multiple selected nodes (via the delete key) - Fix spacebar key (should be on key release- so it doesnt repeat while held) - new key binding- ctrl+space while editing a node will switch to edit the next node - new key binding- ctrl+enter while editing a node will save and close the node - run document format prettify
A little update today - I added another usability feature 👍 |
@charblar this is shaping up to be an epic release and I have addressed your request - it is no longer spitting out an error :) Can you tell me what else needs to be done to get this merged? |
...if no nodes exist for them
I really love the new features @blurymind +1 , but (and I don't want to sound like an ungrateful ***,) i wished you didn't run prettify... or at least not in the same commit as other changes. |
@julsam sorry- its a habbit from another project. I can undo that if @charblar requests it :) |
New build out - go grab a copy! :) |
@blurymind Hey, I was out of country the past week and am taking a look at all of this now. Thank you for you patience. For the remainder of this PR I request that we hold off on features and changes outside the scope of porting to Electron. |
@charblar Hi no problem. I will stop adding any new features and focus on the porting. From my tests the electron port seems to work fine. Can you please test and review it :) I hope I haven't introduced any regressions |
@blurymind Looks good to me, I would ask that you first ignore the .vscode directory first and remove the existing files from inside of it and then we can merge it in. |
as requested
@charblar It is done now :) |
Just to add more feedback: I've been using a modified version of @blurymind 's electron port for the last 2 weeks, I have not encounter any problems so far, it's very stable. I've been using it only on windows though (win7 x64). |
@julsam thank you for taking the time to test it. I noticed that you even merged my changes to your fork (https://github.com/julsam/VineEditor) which is flattering 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, merging in.
@charblar Thank you !! 🎉 😊 🎉 🍾 |
Hi, this is somewhat of a big change pull, so please bear with me
It ports Yarn over to electron, while also adding a couple of new features:
(addressing #34 )
(addressing #29 )
file drag and drop (including support for dropping multiple files )
(addressing drag file in to Yarn makes yarn die #32 )
Automatically create New Nodes from [[new]] and [[new|choice]] - if no nodes exist for them:
(addressing Create new nodes from links when closing a node? #27)
Ability to run more than one instance of Yarn
(addressing Multiple yarn instances not possible #59 )
Lots of fixes and new key bindings
I am not sure if the shift to electron would be welcome by the original creators:
@InfiniteAmmoInc , @seiyria and @beeglebug
Please let me know,so I know if a better route for me is to fork it to "Yarn-plus" or "Yarn-electron" or something
In order to try it just run
npm install
then
npm start